fix issue with 'Expected segment begin' #113

iamtorsten / libfintx

Moved to https://github.com/libfintx/libfintx - please use the new repository!

https://github.com/libfintx/libfintx

GNU Lesser General Public License v3.0

115 stars 40 forks source link

fix issue with 'Expected segment begin' #113 #115

Closed leo-schick closed 1 year ago

leo-schick commented 1 year ago

fix issue with 'Expected segment begin'

redesign SplitSegments use IEnumerable instead of List (performance improvement)
add MessageHelper.ReplaceNewLine to fix unit tests when checking out the git repository with different line ending than Environment.NewLine returns

leo-schick commented 1 year ago

@iamtorsten Can you verify if my PR is ok? I could split it into several once if you like...

freddy6218 commented 1 year ago

Works like a charm :)

leo-schick commented 1 year ago

@freddy6218 does this mean that #113 is now solved?

I was not sure if the error with segment HITANS was that it wasn't implemented or that the unit test needs fixing because a wrong method was called.