search

iamtr / pe

0 stars 0 forks source link

Without specifying file name to export find_and_export overwrites previous defaultfilename.json #5

Open iamtr opened 4 months ago

iamtr commented 4 months ago

Steps to recreate:

  1. find_and_export friends exports to defaultfilename.json

image.png

JSON File:

image.png

  1. find_and_export colleagus exports to defaultfilename.json

image.png

JSON File:

image.png

This is really bad, as it overwrites previous data in defaultfilename.json. The more ideal way to do this would be to put something like defaultfilename (1).json, as the case in windows

soc-pe-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

defaultfilename.json get overwritten everytime find_and_export is executed

This may cause user to lose the previous data everytime this command is executed.

Output for find_and_export friends:

image.png

Output for find_and_export hi:

image.png

Might be better if the filename parameter is made compulsory instead of optional :D

[original: nus-cs2103-AY2324S2/pe-interim#5386] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We reject the bug. The reasons are as follows:

  • This is an intended feature, as some users might not desire to type in many arguments.

  • Moreover, users are able to simply retype the find_and_export command to export the desired group of individuals even if it has been overwritten.

    Items for the Tester to Verify

    :question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This causes unintentional loss of data. Also, to prevent this, there should be a warning a guardrail to prevent loss of existing data.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This causes unintentional loss of data, and it is quite catastrophic. It fails silently without informing the user.