search

iamtrask / DEPRECATED

DEPRECATED - do not use!!!
Apache License 2.0
349 stars 48 forks source link

:page_facing_up: docs(docker): minutes from todays meeting #34

Closed anoff closed 6 years ago

anoff commented 6 years ago

Minutes from the discussion about docker design/usage.. Hope I captured everything in the notes.

cypherai commented 6 years ago

Nice, the ability to retrigger new builds if a base image is changed is indeed important.

What can we do about the CI testing strategy? Shoûd we run tests within the containers?

anoff commented 6 years ago

What can we do about the CI testing strategy? Shoûd we run tests within the containers?

The consensus during the meeting was that testing happens on feature branches, so everything merged to develop should work. In addition only developers would use :edge builds. The :latest builds will be based on master commits so they should be stable enough.

I've never done testing within a built container. I usually try to keep images as small as possible i.e. dropping test code etc.