iamtrask / DEPRECATED

DEPRECATED - do not use!!!
Apache License 2.0
349 stars 48 forks source link

docs($readme): change first sentance of algorithm section under workflow #59

Closed AdamJChen closed 6 years ago

AdamJChen commented 6 years ago

Changed the style of the first sentence to match the previous sections. In addition, being able to choose weights based on a previous model wasn't clear to me until you read the text in the parentheses. I thought this added a bit more smoothness to the flow of the paragraph.

cereallarceny commented 6 years ago

@AdamJChen Mark me as an approved reviewer and I'll merge.

AdamJChen commented 6 years ago

@cereallarceny a little new to this. How do I mark you as an approved reviewer?

cereallarceny commented 6 years ago

All good! On the right side of this pull request, you can see "Reviewers" and "Assignees". Put my name under both.

AdamJChen commented 6 years ago

ah ok haha. I still need a bit of help... :( There isn't a way for me to edit anything on the right of this pull request. I can't change the text under "Assignees" and there is no button. Your name is already under "Reviewers". Thanks for your patience!

anoff commented 6 years ago

Only contributors are allowed to edit reviewers/assignees. Seems like you're not allowed to write Docs @cereallarceny 😛

cereallarceny commented 6 years ago

Incredible @anoff. It appears I've deemed myself unworthy of my newly revoked credibility. ;)

AdamJChen commented 6 years ago

@anoff @cereallarceny Thanks guys! :D