search

iamtrask / OM-Welcome-Package

Everything you need to know to contribute to OpenMined!
Apache License 2.0
216 stars 22 forks source link

OpenMind Teams Map incompatible with GitHub dark mode. #67

Open cozek opened 3 years ago

cozek commented 3 years ago

The OpenMind Teams map is incompatible with GitHub's Dark Mode. Perhaps it should be updated. I have attached a screenshot of it herewith.

Screenshot 2020-12-12 at 6 54 14 PM
ProPriyam commented 3 years ago

If this issue is still open, I would like to be assigned to it.

bogomil commented 3 years ago

This is an image, isn't it?

souravcipher commented 3 years ago

Submitted PR! #69

4mber commented 3 years ago

Hey @souravdotpy - looks like the image you submitted doesn't actually fix the issue. The way to fix it would be to change the text to a shade of grey (or any other color) that shows up well on both a dark or light background.

The original diagram was made using MindNode, and I'm sure there have been a ton of changes since the last time it was made.

So it might be a good idea to make a new one that's accurate and has a color that works for both light and dark mode.

Should I assign it to you @souravdotpy ? Or @ProPriyam @bogomil @cozek - anyone who is interested, feel free to submit a PR (but maybe claim it here first so we don't have several people putting a lot of time into it at once). :)

darigovresearch commented 8 months ago

Thanks for raising this and the PR! Is this error still occurring and can this be closed?