search

iamtrask / Sonar

DEPRECATED - Decentralized Machine Learning Server (hosted on Blockchain)
Apache License 2.0
141 stars 49 forks source link

Added a Dockerfile to automate truffle migration #1

Closed ghost closed 7 years ago

ghost commented 7 years ago

Compiled truffle, but we'll run the migrate in a swarm or network where we actually wanna migrate. We'll setup the command in a docker-compose or we'll set the command when we run docker run.

anoff commented 7 years ago

Why exactly do you not run migrate? In the initial setup everything will be local and most likely just a docker-compose or 3-4 individual docker run commands to spawn the whole system. Wouldn't it be possible to bake the truffle migrate into the image itself?

ghost commented 7 years ago

Because you might wanna pass in --network development. But, I guess I could make truffle migrate an entrypoint.

kevinahuber commented 7 years ago

I'll defer to @anoff on this one for review

anoff commented 7 years ago

Discussed a bit about this one with @TheOriginalAlex on slack yesterday. I think it would really benefit if we can have a reproducible docker image of Sonar that ships with the contract deployed. That would enable us to hardcode the contract address for the hydrogen milestone making initial setup easier.

@TheOriginalAlex what's your take on this? Should we merge this PR as a first step and start another one? Code-wise this PR LGTM

ghost commented 7 years ago

@anoff: I will come back and address that.

iamtrask commented 7 years ago

given that we have a followup issue for the desired improvements. I'll go ahead and merge this guy. Great work @TheOriginalAlex !!