iamtrask / Sonar

DEPRECATED - Decentralized Machine Learning Server (hosted on Blockchain)
Apache License 2.0
141 stars 49 forks source link

dont depend on global truffle install #11

Closed axelhodler closed 7 years ago

axelhodler commented 7 years ago

currently we use npm install -g truffle. Meaning the truffle version (and thus the solidity compiler) will be different on every developers system. IMHO this always leads to issues.

suggestion: init package.json, install truffle there and call via ./node_modules/.bin/truffle, this can be abstracted into a truffle.sh. what do you think?

@anoff

anoff commented 7 years ago

Sounds great! However we shouldn't introduce .sh files as entry points. Instead try to abstract calls with npm run truffle/migrate.. or a Makefile. That way we can have a single (or double 🙄) entrypoint for scripts across all repositories in OpenMined. The make/npm could call a .sh behind the scenes though of course.

axelhodler commented 7 years ago

good idea, forgot the npm scripts functionality there for a moment

axelhodler commented 7 years ago

in progress