search

iamtrask / Sonar

DEPRECATED - Decentralized Machine Learning Server (hosted on Blockchain)
Apache License 2.0
141 stars 49 forks source link

Update Readme with Ethermint Deployment #32

Closed jeamick closed 6 years ago

jeamick commented 6 years ago

Addition of Ethermint Deployment

adrianbrink commented 6 years ago

Thank you very much. This looks very promising.

Could you remove everything that has currently a todo. For example the Docker section. Also, let's group the installation for Ethermint and Tendermint and make sure that they follow the same format.

Besides that it looks awesome.

anoff commented 6 years ago

Is there a possibility to run ethermint in a docker container similar to how we currently do it with testrpc?

jeamick commented 6 years ago

I think, before making the docker container, people should test it in order to know if there are some problems with the setup with Ethermint. And when we are sure that it is totally working we can do the docker container.

iamtrask commented 6 years ago

I agree with @jeamick

axelhodler commented 6 years ago

the dockerizing would be to make the setup easier for users such as they do not need to have a local go/ethermint/tendermint/geth install.

on a sidenote: could we opt for having the current default (docker / vanilla ethereum) and ethermint side by side? As it is now the ethermint docs overwrite the old docs.

iamtrask commented 6 years ago

@axelhodler I agree. I believe @jeamick and I also discussed this offline. In theory the main Readme should offer both as branches... perhaps in separate Markdown files.

iamtrask commented 6 years ago

That being said, I'm a big fan of the tutorial for building ethermint locally as it's not only useful for docker experts to be able to dockerize but also makes for a good fallback option.

anoff commented 6 years ago

Especially if you want to roll something out to several people it makes sense to do so via docker. A non docker solution is prone to 'works on my machine' problems and it will not integrate with the current setup as this is purely docker based.

jeamick commented 6 years ago

Yes @anoff you're right! I will try to make a video demo for this repo. If someone can do the docker file because I'm not an expert on it.

So to make things clear, let's make to differents repo right?

jeamick commented 6 years ago

how can I call it ?

iamtrask commented 6 years ago

given the other PR, i'll go ahead and close this one :) Great job!

adrianbrink commented 6 years ago

@iamtrask Could you reference the other PR here.