search

iamturns / eslint-config-airbnb-typescript

Airbnb's ESLint config with TypeScript support
MIT License
1.05k stars 98 forks source link

'@typescript-eslint/indent' rule is broken upstream and should be removed #310

Open cseas opened 1 year ago

cseas commented 1 year ago

This rule is broken and currently there's an open issue on the typescript-eslint repository mentioning that it won't be fixed anytime soon: https://github.com/typescript-eslint/typescript-eslint/issues/1824

There are many instances where this rule reports errors incorrectly. One such example is mentioned below:

Screenshot 2023-01-01 at 6 56 14 PM

I don't get any errors as mentioned in https://github.com/iamturns/eslint-config-airbnb-typescript/issues/98 but removing this rule would also help everyone facing that as well.

I'd assume most people don't face issues with this error since the Prettier eslint config turns it off.

Rule to remove: https://github.com/iamturns/eslint-config-airbnb-typescript/blob/master/lib/shared.js#L97

Kenneth-Sills commented 3 months ago

Same as the other issue, the Typescript rule was outright removed and this is being migrated to ESLint Stylistic. Once the upstream Airbnb config is updated, the override will be removed entirely.