search

iamturns / eslint-config-airbnb-typescript

Airbnb's ESLint config with TypeScript support
MIT License
1.05k stars 98 forks source link

Not sure why this is happening. Deploying on AWS Amplify. #342

Closed mrjackyliang closed 3 months ago

mrjackyliang commented 8 months ago

I'm not even sure if I should be posting here, since this seems more like an AWS Amplify thing (or a Node issue in general), but my package.json has these versions:

    "@typescript-eslint/eslint-plugin": "7.1.1",
    "@typescript-eslint/parser": "7.1.1",
    "eslint-config-airbnb-typescript": "18.0.0",

But AWS Amplify is using eslint-config-airbnb-typescript@17.1.0. Is there something I'm missing here?

2024-03-06T19:31:58.365Z [WARNING]: npm ERR! code ERESOLVE
2024-03-06T19:31:58.372Z [WARNING]: npm ERR! ERESOLVE could not resolve
                                    npm ERR!
                                    npm ERR! While resolving: xxxxx@1.2.0
                                    npm ERR! Found: @typescript-eslint/eslint-plugin@6.19.0
                                    npm ERR! node_modules/@typescript-eslint/eslint-plugin
                                    npm ERR!   dev @typescript-eslint/eslint-plugin@"7.1.1" from the root project
                                    npm ERR!   peer @typescript-eslint/eslint-plugin@"^5.13.0 || ^6.0.0" from eslint-config-airbnb-typescript@17.1.0
                                    npm ERR!   node_modules/eslint-config-airbnb-typescript
                                    npm ERR!     dev eslint-config-airbnb-typescript@"18.0.0" from the root project
                                    npm ERR!
                                    npm ERR! Could not resolve dependency:
                                    npm ERR! dev @typescript-eslint/eslint-plugin@"7.1.1" from the root project
                                    npm ERR!
                                    npm ERR! Conflicting peer dependency: @typescript-eslint/parser@7.1.1
                                    npm ERR! node_modules/@typescript-eslint/parser
                                    npm ERR!   peer @typescript-eslint/parser@"^7.0.0" from @typescript-eslint/eslint-plugin@7.1.1
                                    npm ERR!   node_modules/@typescript-eslint/eslint-plugin
                                    npm ERR!     dev @typescript-eslint/eslint-plugin@"7.1.1" from the root project
                                    npm ERR!
                                    npm ERR! Fix the upstream dependency conflict, or retry
                                    npm ERR! this command with --force or --legacy-peer-deps
                                    npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
                                    npm ERR!
                                    npm ERR!
                                    npm ERR! For a full report see:
                                    npm ERR! /root/.npm/_logs/2024-03-06T19_31_54_019Z-eresolve-report.txt
                                    npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2024-03-06T19_31_54_019Z-debug-0.log
2024-03-06T19:31:58.539Z [ERROR]: !!! Build failed
Kenneth-Sills commented 3 months ago

Are you still having trouble with this? Would it be possible to create an MVP to reproduce this? A repo would be ideal, but if you can create just a package.json that does it and post it here, that'd be fine too.

mrjackyliang commented 3 months ago

If i get the chance to reproduce it again soon, I'll update it here. But for now, I'll close the issue off.