Improve add text feature

iamutkarshtiwari / Ananas

An easy image editor integration for your Android apps.

MIT License

250 stars 112 forks source link

Improve add text feature #68

Open thirstycoda opened 3 years ago

thirstycoda commented 3 years ago

Changed add text implementation to be similar to add sticker so scale and rotate is controlled with a handle instead of gestures
Added ability to supply the library with fonts for the user to choose from when adding text

rtz333 commented 3 years ago

App crash when i clicked "Default" in TextEditorDialogFragment. I think it because you set: carouselPicker.setCurrentItem(initialFontPosition); And why you remove Sticker?

thirstycoda commented 3 years ago

The crash occurs when the user's default font is not one of the specified fonts. This has been resolved by adding the user's default font to the set if it is not already in it.

It's been a long time since I worked on this so I can't remember the reason for all of the changes but the sticker function still exists. If you are referring to why it was removed from EditImageActivity.java, I don't believe it was being used by that class

rtz333 commented 3 years ago

Thanks for your answer. I want using your fork project and i see you don't use sticker anymore. I wonder if this function has any problem?

thirstycoda commented 3 years ago

I've not used the sticker function much but it seems to work well. I didn't notice any problems. The reason I removed it from my fork was to reduce the size of the library. It was not a feature I wanted to offer in my app and removing it allowed me to remove the sticker images which collectively are over 5mb in size.

rtz333 commented 3 years ago

can you please suggest me how to set the text shadow and opacity? It makes me feel difficult. Anyway, thank you very much for your fork project, it helped me quite a lot