search

ian-andrich / PythonPengines

A Python interface to the Prolog pengines library. Makes it exceedingly easy to call out to SWI-Prolog within Python!
MIT License
12 stars 9 forks source link

Application keyword in PengineBuilder has no effect #12

Closed peterkamatej closed 5 years ago

peterkamatej commented 5 years ago

The reason is that in the getRequestBodyCreate() method, the following is missing: if self.application is not None: data["application"] = self.application

I have made a commit which fixes this issue, but it seems I have no rights to push a new branch and create a pull request.

ian-andrich commented 5 years ago

I'm new to hosting public repositories, is there anything that I need to do so you can make a pull request?

peterkamatej commented 5 years ago

I´m new also to contributing to public repositories :-). Maybe you could add me as a contributor somehow?

cmungall commented 5 years ago

Anyone should be able to make a PR. Matej, did you remember to fork first?

(or if it small just paste the results of git diff here...)

On Tue, Jun 18, 2019 at 11:17 AM ian-andrich notifications@github.com wrote:

I'm new to hosting public repositories, is there anything that I need to do so you can make a pull request?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ian-andrich/PythonPengines/issues/12?email_source=notifications&email_token=AAAMMOI3SJIUSF57MXDUMRDP3EREVA5CNFSM4HY5G3U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7QKBQ#issuecomment-503252230, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMMOM5WW2U7HGGYO5ADPLP3EREVANCNFSM4HY5G3UQ .

peterkamatej commented 5 years ago

I did the fork, but later, and then forgot to push to my fork instead of the main one :-) Now it's ready I think

ian-andrich commented 5 years ago

Closed by merging in pull request. Congratulations again!