search

ian-cox / Kirby-Structure-Tabs

Tabbed Fields for Structured Content
39 stars 4 forks source link

Resizing the Modal panel #1

Closed xu-chris closed 9 years ago

xu-chris commented 9 years ago

First: great plugin! After I've played a bit I think this has great potential to be the next big Kirby plugin ;-)

In the end my modal dialog looks like this: bildschirmfoto 2015-07-01 um 21 58 42

I think the modal dialog should resize to the size of it's content.

ian-cox commented 9 years ago

Oh, interesting. I haven't pressure tested the plugin yet and it looks like there are some issues when it has a lot of content. I'll have to look into this. Thanks!

xu-chris commented 9 years ago

Look to issue #2. There's the blueprint snippet (yes, it's long!)

ian-cox commented 9 years ago

Thats very strange, I don't remember it doing that when I was working on it this weekend. I just did a fresh install of plainkit and loaded it up and it's definitely an issue.

Would you rather it did something like this?

I'd prefer that the tab's didn't jump around but it might be better than full screen.

modal-content

There is a new CSS class on the modal that I don't remember being there: ( .modal-content-fixed )

If I disable it in the web inspector, I get what you see in the gif above.

ian-cox commented 9 years ago

I'm going to push the changes, let me know what you think.

Thanks!

xu-chris commented 9 years ago

Yeah, I think this is better than before - even when it's a bit difficult because the visual position on the screen of the tabs is changing on different sizes. But I'm not sure if this is really an UX problem. The relative position remains the same so in case of the UI it's consistent.

I'll try that out in a Guerilla UX Test ;-)