search

ian-james / IFS

Immediate Feedback System for student programming assignments and essay writing
MIT License
5 stars 6 forks source link

[Critical Functionality] Skills sometimes cannot be added #108

Closed keeferrourke closed 7 years ago

keeferrourke commented 7 years ago

Bug Report

Description

There is a problem on the /skills route where updating values under 'Course Skills' does not update 'Student Skills. I have attached a screen recording of this issue and screen shots of the Admin pages to show what is currently in my database.

image image image image image

Expected behaviour

Linked List skills should have been added to my Student Skills.

Actual behaviour

Nothing happened.

Steps to reproduce

  1. Setup databases similar to mine, as shown in screenshots.
  2. Make student select proficiency in one skill.
  3. Go back to student skill page and attempt to increase proficiency in a new class skill.
  4. Skill fails to be added to student skills.

System information

IFS Version

v0.0.2

ian-james commented 7 years ago

This bug has been introduced and reintroduced lately as the dashboard ui has been changing it breaks the jquery. Although, since the last couple commits there seems to be bigger issues with the dashboard.

keeferrourke commented 7 years ago

@ian-james sorry about that; I wasn't aware. I didn't think that revising the dashboard layouts and styling via classes would could have such an effect.

The only issue I have come across with the latest revisions is the one affecting the /skills route.

ian-james commented 7 years ago

No worries, its a good indication that the code should be changed too. If changing the UI breaks the code it's usually can be done better. Tried to improve to code.

ian-james commented 7 years ago

Found out was actually reference to old controller no longer existing in project...so none of the angular was working wasn't too bad a fix. Although not sure why the tooltips still aren't working code seems correct.

ian-james commented 7 years ago

Should be resolved fixed jquery. Reopen if not true.