search

ian-james / IFS

Immediate Feedback System for student programming assignments and essay writing
MIT License
5 stars 6 forks source link

IFS->Tool Page->Tool Selection #145

Closed ian-james closed 6 years ago

ian-james commented 6 years ago

The enable/disable clicking easily gets out of sync with 1 or 2 presses.

Visual will show tool is disable but dropdown will be visible and vice-versa.

ian-james commented 6 years ago

Adding Rhys to do a peer review of these features. Notice a couple issues but didn't have time to document before leaving.

ryoung2512 commented 6 years ago

The enable disable of a tool seems to work fine for me. However, switching between programming and writing does not.

What I tried:

  1. Regular clicking of the toggle button - passed
  2. Spam clicking of the toggle button - passed
  3. Changing contents of div inside and toggling - passed
  4. Toggling tool settings visibility, then toggling the visual - passed
  5. Tried switching between programming and writing then enabling/disabling - failed

To reproduce the error I found:

  1. Go into preferences, set preferred assessment tool to writing.
  2. When on tool selection page, change from writing to programming.
  3. You can now no longer choose writing anymore, it will just keep displaying programming. Also, neither button is highlighted anymore.

Try switching it to a uikit switcher. It will be a lot more responsive that way as well.

Let me know if you have any questions!

kglovern commented 6 years ago

I have the same issue as Rhys with switching between programming and writing tools on the new interface. The bug is due to the incorrect value being stored as "pref-toolSelect" option.

To reproduce: 1) Visit "/preferences" and select writing or programming 2) In MySQL client, "select from preferences where toolName="pref-toolSelect"; shows the correct value of 'programming' or 'writing' 3) Now use the tool option on the "/tool" route to try to swap between the two - user is stuck on programming as stated above 4) "select from preferences where toolName="pref-toolSelect"; value is now the html source of the page instead of a value of either "writing" or "programming"

Check what is being passed as the toolSelect value - the HTML server response is being stored as the value instead of the actual toolSelect value.

ndomenic commented 6 years ago

I am unable to reproduce this error using both of the aforementioned steps. It never sticks for me, and the database is always updated. I am testing this on the latest version of the development branch.

ian-james commented 6 years ago

Ok, well then we could close this bug. I'll double check when I get back. But open one for the other issue and and assign to whoever is free

On Mon, Jul 9, 2018, 5:55 PM ndomenic notifications@github.com wrote:

I am unable to reproduce this error using both of the aforementioned steps. It never sticks for me, and the database is always updated. I am testing this on the latest version of the development branch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ian-james/IFS/issues/145#issuecomment-403632951, or mute the thread https://github.com/notifications/unsubscribe-auth/AEOnbhlpzTnkyaiMKNvfbFguWvL5jCoqks5uE9FIgaJpZM4VDMv_ .

ian-james commented 6 years ago

Any differences in browsers or environments?

ryoung2512 commented 6 years ago

We all tested on firefox, only difference is that Kevin and I use Macs.. not sure if that could cause anything.

ian-james commented 6 years ago

I would check chrome too since it's a main supported browser.

Mac might cause differences.

On Tue, Jul 10, 2018 at 9:48 AM, Rhys Young notifications@github.com wrote:

We all tested on firefox, only difference is that Kevin and I use Macs.. not sure if that could cause anything.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ian-james/IFS/issues/145#issuecomment-403828377, or mute the thread https://github.com/notifications/unsubscribe-auth/AEOnboGbyrlJ2nGLpm0A5HLcEsshI-rWks5uFLCVgaJpZM4VDMv_ .

ryoung2512 commented 6 years ago

Grant was able to reproduce this error that Jamey was talking about. It has to do with clicking outside of the pill, slightly. The div is too large and not rounded causing it to sometimes be offset since you are not clicking the actual button. So this thread should stay open until @ndomenic can fix it.

GrantDouglas commented 6 years ago

I found a fix that can be used. I made the buttons square instead of rounded to remove the buffer area around the button. It looks fine to me, but might need other peoples perspectives on it.

GrantDouglas commented 6 years ago

I looked through the main css file and found the cause of the problem. Will make a pull request on the branch it is currently on.

ian-james commented 6 years ago

Awesome. Thanks!

On Mon, Jul 16, 2018 at 1:03 PM, Grant Douglas notifications@github.com wrote:

I looked through the main css file and found the cause of the problem. Will make a pull request on the branch it is currently on.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ian-james/IFS/issues/145#issuecomment-405316290, or mute the thread https://github.com/notifications/unsubscribe-auth/AEOnbii5biBdS8gFZ6683xVQDaw35Cshks5uHMdQgaJpZM4VDMv_ .

ryoung2512 commented 6 years ago

It was merged in today to development. I tested it out and the bug is no longer there. Going to go ahead and close this issue.