search

ian-james / IFS

Immediate Feedback System for student programming assignments and essay writing
MIT License
5 stars 6 forks source link

Tool faster load #172

Closed ndomenic closed 5 years ago

ndomenic commented 6 years ago

This branch contains minor changes that overall drastically speed up the loading time of the tool page to enhance the user's experience. I have cleaned up a lot of the JQuery that makes the selects at the top of the page for course/assignment load a bit faster, and background loading is no longer visible to the user. I have also removed all Angular from page rendering and moved it directly into the res.render call in the toolRoutes. This means that the page now loads everything at once and is a lot snappier, rather than loading a template and then having an Angular controller go to fetch tool data after the page has loaded to fill in the template.

There shouldn't be anything that has broken anything, as these are all minor changes that are purely for performance. However since this affects the a major part of IFS, I have made this pull request as it seems necessary for someone other than myself to review what I have done.

ian-james commented 5 years ago

Have integrated the changes to remove toolController. Required a couple other fixes and given the state of dev branch just manually integrated desired code. Thanks Nick!!