search

ian-ross / arb-fft

Pure Haskell arbitrary length FFT library
https://www.skybluetrades.net/haskell-fft-index.html
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

0.3.0.0.1: update cabal file and a bit of hlinting #9

Closed jrp2014 closed 5 years ago

jrp2014 commented 5 years ago

(I've also removed some package upper bounds.)

Passes tests and runs:

cabal new-exec profile-256
benchmarking...
time                 45.40 μs   (44.71 μs .. 46.24 μs)
                     0.997 R²   (0.995 R² .. 0.998 R²)
mean                 45.74 μs   (45.40 μs .. 46.27 μs)
std dev              1.383 μs   (1.018 μs .. 1.979 μs)
variance introduced by outliers: 31% (moderately inflated)
Running 1 test suites...
Test suite basic-test: RUNNING...
Tests
  FFT vs. DFT:         OK (1.37s)
    +++ OK, passed 100 tests.
  FFT/IFFT round-trip: OK (0.04s)
    +++ OK, passed 100 tests.

All 2 tests passed (1.41s)
Test suite basic-test: PASS

Thanks for all the work putting this together. I may have a go at some further cleanup thrown up by compiling with -Wall

ian-ross commented 5 years ago

Thanks for doing this! For the redundant imports, I'd be quite happy for you just to delete them completely: no need to comment them out. If you like, I can add you as a collaborator on this repo, so you can make changes yourself. I can add you as a maintainer on Hackage too, so that you can do releases if you're comfortable with that. If not, just let me know and I'll cut a release when we've merged your changes here.

jrp2014 commented 5 years ago

Many thanks, Ian. I'd be happy to be added as a collaborator and included as a maintainer; go ahead and merge / release these for now.

I'll have a go at including a Makefile to make it easier to set up builds / tests, enable profiling, etc.

There are also a few more tweaks that I need to investigate, reread your blog posts, and have a look at the Real version... JOhn