search

ian4hu / Clipy

Clipboard extension app for macOS.
https://clipy-app.com
MIT License
256 stars 17 forks source link

fix wording in Beta preferences pane #34

Closed tessus closed 5 years ago

tessus commented 5 years ago

I've added the word from to items 2 and 3, otherwise the action would mean to delete the entire history. But what actually meant is that the current/selected item is removed from the history.

tessus commented 5 years ago

@ian4hu did you see my comment? It would be great, if you could add that before you create a new release. Unless the text really means what it says and it deletes the entire history. (which I doubt)

(I had to delete the comment and add it again, because I mentioned the wrong person)

ian4hu commented 5 years ago

@tessus Thanks for your contribution.

I will review it later. The wording issue is not only in .xib file, but also in i18n .strings file.

tessus commented 5 years ago

@ian4hu I'm sorry, I don't know how to update the string files. I guess you mean the file CPYBetaPreferenceViewController.strings in the different language directories. I remember there was a way to update them automatically, but I can't figure it out. I forgot.

tessus commented 5 years ago

@ian4hu may I ask how you updated the other files? Did you do it manually or is there a Xcode tool to automatically update the other files? I mean this part /* Class = "NSButtonCell"; title = "Paste and delete from history"; ObjectID = "M5n-Mr-02l"; */

ian4hu commented 5 years ago

@ian4hu may I ask how you updated the other files? Did you do it manually or is there a Xcode tool to automatically update the other files? I mean this part /* Class = "NSButtonCell"; title = "Paste and delete from history"; ObjectID = "M5n-Mr-02l"; */

Execute the build command from Xcode > Product > Build menu item will trigger BartyCrouch's Build Phase, and then the BartyCrouch update the other files automaticly (only the original text, the translated text is untouched).

image

tessus commented 5 years ago

Thx, for the info. I hoped that was an Xcode feature, but I guess Apple didn't think that far ahead....