search

ianBBB / boa-constructor

Updating the Boa Constructor IDE for operation with python 3.X and wxpython 4.2.X
https://ianbbb.github.io/boa-constructor/
0 stars 0 forks source link

Hard coded paths in source #15

Open bleeisme opened 7 months ago

bleeisme commented 7 months ago

In Palette.py @ line 275

PyHelpBrowser.browser.LoadURL(r"C:\Users\Ian-17\Documents\boa test area\HELP work area\python\python work area\python-3.9.17-docs-html\python-3.9.17-docs-html\index.html")

Also: Execution of command '"C:\Users\Ian-17\AppData\Local\Programs\Python\Python312\python.exe" Boa.py ' failed (error 2: The system cannot find the file specified.)

But I cannot find where that path is stored yet.

ianBBB commented 7 months ago

Thanks for raising that. I had been looking at it but just not implemented the fix yet. I have now and the both dev and the master have been updated.

Could you try the updated code and confirm that it works OK, please.

PS At first I assigned this to you to test the new code but then It occurred to me that you may not want this, so I have unassigned you. Apologies if I overstepped the mark there.

bleeisme commented 7 months ago

I don't mind being assigned tasks, as long as I am not held to a timeline on finishing them.

I will update my code to the latest and test - Thanks for the effort.

Also, I have no experience making updates / pull requests. I just found and fixed an issue with .m_col . I am going to try to make that fix my first pull request.

ianBBB commented 7 months ago

I once worked with a project manager who said he liked deadlines, he like the "whooshing" sound they made as they went past. No holding to timelines here. I don't even hold myself to timelines. Thanks for the effort you are putting in. Regarding updates and Pull Requests; can you do these on the Dev branch please and leave the Master as the formal current release. Once I approve it into dev, I'll move it to the Master. I think the general idea is to accumulate updates in dev over time then create a new release of Master with all those changes rolled in. Like you, I am still learning this GitHub beast. I did my first Pull Request ever just two weeks ago and that was with the help of a friend.