search

ianb821 / IBActionSheet

Customizable iOS 7 style UIActionSheet
MIT License
307 stars 65 forks source link

IBActionSheet doesn't grey out status bar #10

Open samlester opened 10 years ago

samlester commented 10 years ago

We're using this framework for a project and I've just noticed that the status bar isn't greyed out when using the IBActionSheet. It's particularly noticeable when it's set to be white.

Is this just a limitation of the system or can it be fixed?

Thanks!

ianb821 commented 10 years ago

Awesome, glad to hear it's being used. What version are you targeting with your project, and are you using a UINavigationController?

On Sat, Feb 22, 2014 at 8:39 PM, Sam Lester notifications@github.com wrote:

We're using this framework for a project and I've just noticed that the status bar isn't greyed out when using the IBActionSheet. It's particularly noticeable when it's set to be white. Is this just a limitation of the system or can it be fixed?

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/ianb821/IBActionSheet/issues/10

samlester commented 10 years ago

We're targeting iOS7 and using a UINavigationController.

ianb821 commented 10 years ago

Okay, when you're calling showInView are you doing it like this:

[actionSheet showInView:self.navigationController.view];

or are you just doing:

[actionSheet showInView:view];

samlester commented 10 years ago

The first one.

samlester commented 10 years ago

It looks like it's doing the same in the example project – it's just more difficult to tell because the status bar is black to start with. When the phone is plugged in the green battery icon isn't dimmed out.

ianb821 commented 10 years ago

That's odd, I'm using it in a project with the same setup and it dims it. Try changing line 508 of IBActionSheet to self.transparentView.alpha = 1.0; And then seeing if it's blacking it out or not.

On Sat, Feb 22, 2014 at 9:30 PM, Sam Lester notifications@github.com wrote:

The first one.

Reply to this email directly or view it on GitHub: https://github.com/ianb821/IBActionSheet/issues/10#issuecomment-35822842

samlester commented 10 years ago

It's still not working. For testing we've changed the status bar on the example app to white so we can see the issue better. Here's what we're seeing:

photo 23-02-2014 03 37 33 photo 23-02-2014 03 37 29

ianb821 commented 10 years ago

Yeah, that definitely doesn't look dimmed out. I'm honestly not sure, I've never run into it. I'll have to dig around and see what I can come up with.

On Sat, Feb 22, 2014 at 9:40 PM, Sam Lester notifications@github.com wrote:

It's still not working. For testing we've changed the status bar on the example app to white so we can see the issue better. Here's what we're seeing: photo 23-02-2014 03 37 33

photo 23-02-2014 03 37 29

Reply to this email directly or view it on GitHub: https://github.com/ianb821/IBActionSheet/issues/10#issuecomment-35823005

samlester commented 10 years ago

Ok, cool – no rush on our end, it's only a small issue and won't stop us from using it in production. Drop me a line if you find something.

ianb821 commented 10 years ago

Will do, thanks for letting me know about the issue.

On Sat, Feb 22, 2014 at 9:45 PM, Sam Lester notifications@github.com wrote:

Ok, cool – no rush on our end, it's only a small issue and won't stop us from using it in production. Drop me a line if you find something.

Reply to this email directly or view it on GitHub: https://github.com/ianb821/IBActionSheet/issues/10#issuecomment-35823074