ianbelcher / eks-kubectl-action

30 stars 43 forks source link

Make credentials optional, add kubectl output and build container image #11

Closed miguelaferreira closed 3 years ago

miguelaferreira commented 3 years ago

This PR addresses a few issues with this action:

To push the docker container images from the workflow using the github actions GITHUB_TOKEN I followed the process described in the github actions documentation to setup the correct permissions. I did have to create the package repository by pushing an initial image using my PAT.

miguelaferreira commented 3 years ago

@ianbelcher could you please have a look and see if you agree with what I'm proposing.

ianbelcher commented 3 years ago

This looks great Miguel! Thanks for putting in the time to do this.