iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.5k stars 1.44k forks source link

BIP-84 support #151

Closed prusnak closed 6 years ago

prusnak commented 6 years ago

Please add support for BIP-84 : https://github.com/bitcoin/bips/blob/master/bip-0084.mediawiki

It is basically a version of BIP-44 for P2WPKH addresses (similarly as BIP-49 is a version of BIP-44 for P2WPKH-in-P2SH.

Private keys should start with zprv and public keys with zpub.

Magic constants are here: https://github.com/spesmilo/electrum/blob/0a648e2b1cdb7852d80c0626c62984ef01c1c7e9/lib/bitcoin.py#L50

iancoleman commented 6 years ago

Thanks for this.

See https://github.com/iancoleman/bip39/commit/4e9b492ca4e1f90b985cfc2da94bddc60a36e386

prusnak commented 6 years ago

Great!