search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.57k stars 1.45k forks source link

Korean is not supported. #170

Closed munggo closed 6 years ago

munggo commented 6 years ago

Korean is not supported. Please support Korean.

iancoleman commented 6 years ago

Thanks for this.

Wordlist is here: https://github.com/bitcoin/bips/blob/master/bip-0039/korean.txt

I'll add this to the next release.

munggo commented 6 years ago

Thank you. Please be sure to add it in the next release. When do you expect the next release?

iancoleman commented 6 years ago

Should be a new release early to middle of next week.

munggo commented 6 years ago

thank you. Please add features.

iancoleman commented 6 years ago

This has been released in v0.3.4

See https://github.com/iancoleman/bip39/commit/139becaf2cc22c99e2813098c1411164c9baef26 - Add Korean language

Currently the mnemonic is displayed with ideographic spaces, however it should apparently use ascii spaces (see https://github.com/bitcoin/bips/pull/570#issuecomment-372166421). Since the mnemonic is nfkd normalized the difference in spaces don't affect the resulting keys, but it should be changed to use ascii space if that's what's normal for Korean language.

munggo commented 6 years ago

Thank you. But not yet. It is not that simple. If you click the "한국어" button, the sample word will be input and it will work normally. Copy and paste the words in the Textarea Box. "not in wordlist, did you mean able?" Is displayed. This seems to be an ASCII and Unicode issue.

iancoleman commented 6 years ago

Can you please confirm the steps to reproduce this?

I'm using chrome browser and these are the steps I took (which work as expected for me)

  1. Open https://iancoleman.io/bip39/
  2. Select Korean language
  3. Observe a random mnemonic is generated in Korean language
  4. Copy the Korean mnemonic
  5. Remove the "#korean" text from the url
  6. Reload the page
  7. Paste the Korean mnemonic
  8. The language is correctly detected and no errors are shown

Please confirm the steps that you took to see the error where the language is not correctly detected.

munggo commented 6 years ago

I use Safari web browser mainly. It works fine in Chrome. Thank you. Have a nice day.

iancoleman commented 6 years ago

Thanks for reporting the issue with Safari. I don't have immediate access to that browser but when I do later I will try it out and see if I can resolve it since Safari is a very common browser.