search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.57k stars 1.45k forks source link

Toggle bugfix #181

Closed skironDotNet closed 6 years ago

skironDotNet commented 6 years ago

won't merge, but you asked to do this PR

iancoleman commented 6 years ago

What is this fixing? Where was the fix requested?

skironDotNet commented 6 years ago

Read the comment of erasmospunk https://github.com/Coinomi/bip39/pull/8 maybe I just misunderstand, makes no sense to me ...

iancoleman commented 6 years ago

The toggle works correctly in this version so there's no need for this change.

Coinomi changed the address table cells from <span> to <a> when they introduced qr codes; see https://github.com/Coinomi/bip39/blame/master/src/index.html#L423

That would have broken the selector for the toggle feature. Funnily enough there's a test for this feature: https://github.com/iancoleman/bip39/blob/master/tests/spec/tests.js#L901

Considering coinomi "is 59 commits ahead, 361 commits behind iancoleman:master" I think any useful changes they have will need to be cherry-picked.

But thanks all the same for passing on the info as per their suggestion! And thanks for submitting the change to coinomi so that features they break can work as intended again.