search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.5k stars 1.44k forks source link

Added BST - BlockStamp #296

Closed skironDotNet closed 5 years ago

iancoleman commented 5 years ago

Why is deimos removed in segwit parameters? This PR is for blockstamp.

skironDotNet commented 5 years ago

Because deimos word didn't appear anywhere in the source code, no reference to it, and was crushing code execution when put my code under those lines,

deimos

but since I put BST code above deimos we can un-commentthat code. Would you like me to un-comment deimos?

iancoleman commented 5 years ago

Yes please uncomment Deimos for this PR, that part of the code will be investigated in #297.

Thanks for reporting it, this is very unusual both to have unused code and for it to be causing problems. If you have any further details or description please feel free to add it to #297.

skironDotNet commented 5 years ago

I still believe you could merge with deimos commended out but deimos resorted, and re: "this is very unusual both to have unused code" it could get there by mistake of someone, or bad merge.... "and for it to be causing problems"... I'll answer why in #297 as advised. Thanks!