Add Nebulas (NAS) - Githubissues

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes

https://iancoleman.io/bip39/

MIT License

3.49k stars 1.44k forks source link

Add Nebulas (NAS) #314

Closed hostgame closed 5 years ago

hostgame commented 5 years ago

Add support for Nebulas Network

Official website: https://nebulas.io Slip0044 Index: 2718 Chain ID: 2718

iancoleman commented 5 years ago

Please add a test, eg https://github.com/iancoleman/bip39/blob/master/tests/spec/tests.js#L503-L509

How do you suggest I audit the new file nebulas.js which is over 40K lines long and contains minified js. Genuine question.

hostgame commented 5 years ago

@iancoleman test spec added

Yeah. Reviewing minified code is impossible. I replaced nebulas.js with just part of it which is responsible for address generation, but it still big. You can audit uncompiled version. I was using this gulp recipe to build nebulas-account.js.

Nebulas is not a bitcoin fork so it need to use separate library to create addresses as well as ethereumjs-util.js or bchaddrjs-0.2.1.js.

iancoleman commented 5 years ago

Thanks for this, looks good.