search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.49k stars 1.44k forks source link

fixed signing message for DigiByte #331

Closed mctrivia closed 5 years ago

mctrivia commented 5 years ago

Not fixed by this pull request because I could not figure out where it is done but like Bitcoin BIP44,BIP49,BIP84 should be xpub,ypub,zpub respectively.

iancoleman commented 5 years ago

xpub,ypub,zpub are determined by the presence of bip32.public and bip32.private values in segwit-parameters.js

eg ypub is set by values in

bitcoinjs.bitcoin.networks.bitcoin.p2wpkhInP2sh.bip32

and zpub is set by values in

bitcoinjs.bitcoin.networks.bitcoin.p2wpkh.bip32

more info

http://docs.electrum.org/en/latest/xpub_version_bytes.html

mctrivia commented 5 years ago

thanks. have amended pull request to included fixs to bip49, and 84 prefixs

johnnynanjiang commented 5 years ago

@iancoleman @mctrivia, is it ok to merge this PR so that we can continue with our testing? Thanks.

mctrivia commented 5 years ago

yep it now returns correct values and though signing message is not used anywhere i can find now has correct value for those looking to work with the coin.

iancoleman commented 5 years ago

Thanks for this and apologies for the delay! I appreciate it.

johnnynanjiang commented 5 years ago

Thanks for this and apologies for the delay! I appreciate it.

Hi @iancoleman, when would the page be updated?

iancoleman commented 5 years ago

Should be updated this week, just waiting to see if I can fit in some other PRs before deploying.

mctrivia commented 5 years ago

looks like iancoleman.io still not updated unless my phone is just caching and refusing to refresh

iancoleman commented 5 years ago

Yeah sorry still not updated... my bad, been mad busy lately. It's still sitting in my todo list so don't worry I haven't forgotten.

iancoleman commented 5 years ago

Just put out a new release. Thanks for the pushes and reminders :)