Add Elastos - Githubissues

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes

https://iancoleman.io/bip39/

MIT License

3.45k stars 1.43k forks source link

Add Elastos #367

Closed johnnynanjiang closed 4 years ago

johnnynanjiang commented 4 years ago

Implement address derivation for Elastos based on Elastos Keypair JavaScript SDK
Make some changes on top of Elastos Keypair JavaScript SDK to use derivation path m/44'/2305'/0'/0/0, which is standard, whereas current Elastos uses BTC path m/44'/0'/0'/0/0. Changes are in a modified version of Elastos Keypair JavaScript SDK
Address derivation results are verified against the tests in the modified version of Elastos Keypair JavaScript SDK

johnnynanjiang commented 4 years ago

Hi @iancoleman, can you please have a review on this PR? Thanks.

iancoleman commented 4 years ago

Why close? I was too busy to review this immediately but appreciated that you'd submitted the PR.

johnnynanjiang commented 4 years ago

Why close? I was too busy to review this immediately but appreciated that you'd submitted the PR.

Hi @iancoleman , I have raised another PR with squashed commits and test, hope it is easier.

I know you must be very busy, and I tried to contact you via LinkedIn. I'm based in Sydney and happy to help with PR process going forward if you are ok.