fix bech32 prefix monacoin -> mona

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes

https://iancoleman.io/bip39/

MIT License

3.43k stars 1.42k forks source link

fix bech32 prefix monacoin -> mona #402

Closed you21979 closed 4 years ago

you21979 commented 4 years ago

see: https://github.com/monacoinproject/monacoin/blob/f5f97ba42f9b5dbebbc01f5ebef56df53298bafe/src/chainparams.cpp#L151

iancoleman commented 4 years ago

Does this affect any legacy wallets? Should a second network, eg MONA (monacoin bech32 prefix) be added (see below) to retain the old bech32 parameters? If it can simply be replaced I'm happy to merge this PR as-is.

https://github.com/iancoleman/bip39/blob/90f7a5ec9309c755dd06a534190067fa6f1f97fe/src/js/index.js#L2727-L2733

you21979 commented 4 years ago

This fix does not affect legacy wallets. The prefix of bech32 is simply wrong and can be replaced as it is.