feat: rsk network - Githubissues

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes

https://iancoleman.io/bip39/

MIT License

3.52k stars 1.44k forks source link

feat: rsk network #409

Closed bguiz closed 4 years ago

bguiz commented 4 years ago

What

Added a conditional check for isRsk mirroring the isEthereum implementation
Added an implementation of an EIP-1191 compliant address checksum calculator in function toChecksumAddressForRsk

Why

Need to generate addresses with checksums using the correct chainId, as per EIPs:
- EIP-1191, and
- EIP-155, and
- EIP-55

Refs

Verify generated addresses using RSK address validator
Specifications

bguiz commented 4 years ago

@iancoleman bump ^

iancoleman commented 4 years ago

Look good thanks. What happened to rubycoin? I appreciate tidying up the naming regardless of what happened, but I couldn't understand why it changed from libs.bitcoin.networks.rubycoin

bguiz commented 4 years ago

What happened to rubycoin? I appreciate tidying up the naming regardless of what happened, but I couldn't understand why it changed from libs.bitcoin.networks.rubycoin

@iancoleman This is the PR in which the reference to rubycoin reference was added: https://github.com/iancoleman/bip39/pull/396/files

RSK isn't related to rubycoin, and that was an error. Copying @ilanolkies

This one fixes it by defining its own networks, as per the specifications here: https://developers.rsk.co/rsk/architecture/account-based/ I've added this link to the PR description.

ilanolkies commented 4 years ago

It was my mistake setting rubycoin. Actually this updates fix the problem

bguiz commented 4 years ago

Thanks @iancoleman!