search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.42k stars 1.42k forks source link

BIP39 Missing mnemonics word in English #471

Closed Pool-ctrl closed 3 years ago

Pool-ctrl commented 3 years ago

BIP39 Missing " FALL " mnemonics word in English in 12/24 words.

EAWF commented 3 years ago

Strange. I see it in wordlist_english.js on line 68, and I checked the online tool also...it's there. Curious which wordlist you found it missing from?

Pool-ctrl commented 3 years ago

I was using the stand alone below: https://github.com/iancoleman/bip39/releases Please see attached screen shot: Capture Appreciate any hlp you can offer. Thank you.

iancoleman commented 3 years ago

Try without a capital F.

I will add a check for uppercase and an appropriate error message.

I'm hesitant to autocorrect this to lowercase, I feel what the user types is the ultimate source of truth and modifying it automatically is not a helpful user experience.

Pool-ctrl commented 3 years ago

I tried it with both uppercase and lowercase. Try it for yourself. Thanks Regards

On Tue, 23 Feb 2021 at 21:31, iancoleman notifications@github.com wrote:

Try without a capital F.

I will add a check for uppercase and an appropriate error message.

I'm hesitant to autocorrect this to lowercase, I feel what the user types is the ultimate source of truth and modifying it automatically is not a helpful user experience.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iancoleman/bip39/issues/471#issuecomment-784526716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS62THEK6BG7QHQ74SNBAKTTAQNEFANCNFSM4YDAWMMA .

--

iancoleman commented 3 years ago

I tried it with both uppercase and lowercase. Try it for yourself.

I did try it, that's why I posted! Typing 'Fall subject' doesn't work (it gives the same error as the screenshot) but typing 'fall subject' shows a different error (Invalid mnemonic).

If you can send me the file you're using that's not working I'd be interested to have a look.

I tried downloading from github releases, I tried the online copy, both contained the word 'fall'. I can't reproduce the error you're seeing. If you could send me the file by email (ian@iancoleman.io) that would help to understand the problem.

Pool-ctrl commented 3 years ago

Ok. Will do.Thanks