search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.42k stars 1.42k forks source link

fix "blank mnemonic" error when only using a BIP39 seed (no mnemonic phrase) and then changing the coin #486

Closed secinthenet closed 3 years ago

iancoleman commented 3 years ago

Thanks, good catch!

iancoleman commented 3 years ago

This caused a regression on three existing tests

I'll change it back to how it was in the short term.

If you could list the steps to duplicate the error behind this pull request that would be great. That way I can add another test for the issue and see the best way to resolve it while keep the other tests passing.

secinthenet commented 3 years ago

Steps to reproduce the issue:

  1. Set the "BIP39 Seed" field. I used '00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'.
  2. Change the coin from Bitcoin to something else (doesn't matter which other coin)
  3. See an error "Blank mnemonic"
secinthenet commented 2 years ago

@iancoleman any way I can help to bring back this fix?