[ETH - Ethereum] Encrypt private key using BIP38 option does not encrypt private keys

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes

https://iancoleman.io/bip39/

MIT License

3.42k stars 1.42k forks source link

[ETH - Ethereum] Encrypt private key using BIP38 option does not encrypt private keys #514

Open azagniotov opened 2 years ago

azagniotov commented 2 years ago

G'Day @iancoleman ,

I am mucking around with the https://iancoleman.io/bip39/#english ( and I noticed when I choose the aforementioned option by ticking the checkbox, in the "Derived Addresses" table, it is the "Public Key" column values that get encrypted, the values in "Private Key" column remain unchanged as before the encryption option was selected.

Is this a bug or am I blatantly missing something?

Cheers

azagniotov commented 2 years ago

Also, sorry, this is happening when the selected coin is ETH - Ethereum, not for BTC

q9f commented 2 years ago

The Ethereum BIP-38 equivalent is: https://github.com/ethereum/wiki/wiki/Web3-Secret-Storage-Definition#definition