search

iancoleman / bip39

A web tool for converting BIP39 mnemonic codes
https://iancoleman.io/bip39/
MIT License
3.41k stars 1.42k forks source link

coin type of binance coin #625

Open misaqsaadat opened 1 year ago

misaqsaadat commented 1 year ago

Hello. according to link below, coin type of binance should be 714 (or 9006) but in the code this is 60. which should be used for ethereum. is there a reason you use 60 for both binance and ether? which make their private key (and addresses) equal?

https://github.com/satoshilabs/slips/blob/master/slip-0044.md

Uefi1 commented 1 year ago

The author of this release died from coronovirus

misaqsaadat commented 1 year ago

has Ian Coleman passed away? RIP

iancoleman commented 1 year ago

No I haven't passed away.

misaqsaadat commented 1 year ago

Thanks God I'm sorry. I thought "author if this release" is referring you. (then who passed away?) So can you explain why you use 60 for binance? this is commit link : https://github.com/iancoleman/bip39/commit/42e00ef56a00c304090c54ef05ff1fc0dcb148b6

iancoleman commented 1 year ago

Would have to ask @mvillalba who submitted this change in #442

mvillalba commented 1 year ago

I do not recall why it was set to 60 in my original PR. I'm afraid I haven't done anything relating to this in a long time, and I don't recall the specifics.

misaqsaadat commented 1 year ago

Some developer inside my company says that we should use '60' for binance, because it is 'standard'. when I ask why is this 'standard' he says because Ian Coleman did this. this number (60) is only duplicate number in list. so there is no obvious reason why you choose to use 60 instead of 714.