search

iand675 / hs-opentelemetry

OpenTelemetry support for the Haskell programming language
https://iankduncan.com/projects/opentelemetry
BSD 3-Clause "New" or "Revised" License
76 stars 34 forks source link

AWS X-Ray propagator(intent to implement) #115

Closed belevy closed 7 months ago

belevy commented 7 months ago

I am interested in implementing a propagator for AWS X-Ray so that request traces can be linked to CloudFront/API Gateway/ALB in X-Ray.

Is this something that should be implemented in a separate library or committed to this repo? Should there be a contrib namespace/repo to support discovererability?

iand675 commented 7 months ago

Personally I'm quite happy to add it to this repo and add you as a committer. That being said, I think there is a library for this already: https://github.com/MercuryTechnologies/hermes/tree/main/src/Network/HTTP/Headers

belevy commented 7 months ago

I'm talking about connecting X-Trace-Id to the otel trace/span. I don't see what you specifically are referring to in that folder.

EDIT: For reference https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/propagators/aws

iand675 commented 7 months ago

oh sorry, totally wrong link. https://hackage.haskell.org/package/hs-opentelemetry-awsxray is what I meant to link to!

belevy commented 7 months ago

Oh awesome, that makes my life easier :). I guess this proves my point as to discoverability