iand675 / hs-opentelemetry

OpenTelemetry support for the Haskell programming language
https://iankduncan.com/projects/opentelemetry
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

Added instrumentationScope to Logger and LogRecord #127

Closed evanlauer1 closed 5 months ago

evanlauer1 commented 5 months ago

Big Context

Logging Support is being added to hs-opentelemetry. Logging spec

Small (This PR) Context

To comply with the spec, LogRecord must have a field instrumentationScope. Logger provides this field to LogRecords. This PR updates the codebase to match that spec. The InstrumentationLibrary data type was also updated to include schema_url and attributes. The haddock documentation about how to initialize an instrumentationLibrary has not yet been updated because I am unsure about how adding fields to instrumentationScope will affect things and whether it is necessary to add the fields.

Testing

evanlauer1 commented 5 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @evanlauer1 and the rest of your teammates on Graphite Graphite