search

iandees / josm-notes

A JOSM plugin to show OpenStreetMap Notes.
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Open nodes dump files (*.osn, *.osn.bz2) #28

Closed don-vip closed 10 years ago

don-vip commented 10 years ago

The plugin should be able to open notes dump files from this location: http://planet.openstreetmap.org/notes/

ToeBee commented 10 years ago

Yeah, that would be neat, wouldn't it. However it turns out that the format of the API calls and the format of the notes dump is completely different. Like, not even remotely related. Oh, except that they are both XML. So this just went from "provide a different InputStream to the parser" to "write a completely separate parser" :(

@iandees didn't the first version of the notes dump generator produce API-like files? I seem to remember people asking for changes. Can these people be flogged now?

iandees commented 10 years ago

The notes dump format is what the API format should have been :).

I just pushed up a branch that adds the start of a parser for the format in #31.

ToeBee commented 10 years ago

Thanks for the code. I'm working on putting the parsing and API interactions of this plugin into JOSM core. I added your parsing code to that effort (ToeBee/josm@6561064) so I may or may not do work in this plugin to make use of it. We'll see how things go in core.

ToeBee commented 10 years ago

Cleaning out some old issues. The note support in JOSM core has supported opening dump files for several weeks now.