Closed nvkelso closed 4 years ago
I think I finally found a decent path on this one.
The default landing page looks like this:
You can enter a WOF ID and it will use data.whosonfirst.org to figure out which repo to load from or you can pass in your own URL if you want to load a specific branch/fork. In either case, it redirects you to the edit page, but now instead of having a WOF ID in the URL it has an entire URL as a parameter:
That URL is loaded to show in the form and make edits. It uses the wof:repo
property of that doc to decide which repository to make the pull request against.
I dig it!
The only change I'd make is to layout them top and bottom instead of side by side...
ID
URL
Instead of - ID
| URL
Right now it looks like I should do both fields... Or you could make the find by URL just a button that prompts for the URL value with a dialog?
It's also confusing that the text in the boxes isn't actually text, so clicking them doesn't do anything.
we can add e.g.:
prefix on the text you have in those boxes and call it good?
Adjusted alignment and improved placeholder text:
@iandees formatting nit: can you add 2 lines of whitespace between the blue button Find by ID
and the text Find by URL
, please? Then we can close this out...
Ah, another annoyance on the Bootstrap 3 -> 4 upgrade. Gave it some bottom margin:
Works for me :)
If you land on the test page it's blank. So add button at top that says "load WOF place" and accepts URL, to then reload the page with the URL param trick?