On validation error on PR or export, scroll page to top

iandees / wof-editor

A simple Who's on First editor.

https://writefield.nextzen.org/

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

Closed nvkelso closed 4 years ago

nvkelso commented 4 years ago

I kept pressing the PR and export buttons at the bottom of the page wondering why they didn't do anything...

Then, because I had deliberately put in bad values, I scrolled up and noticed some fields had ! next to them saying fix a problem.

Then I scrolled all the way up and saw there were these helpful red alerts. Probably only one general alert is needed, not duplicates.

If there are errors on pressing either PR or Export buttons, we should scroll the page all the way up to show the alerts.

iandees commented 4 years ago

I added scrolling to the top 👍

nvkelso commented 4 years ago

Working for me.