Adding new name: values actually sets label: values

iandees / wof-editor

A simple Who's on First editor.

https://writefield.nextzen.org/

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

Adding new name: values actually sets label: values #42

Closed stepps00 closed 4 years ago

stepps00 commented 4 years ago

https://github.com/whosonfirst-data/whosonfirst-data-admin-in/pull/35 https://github.com/whosonfirst-data/whosonfirst-data-admin-in/pull/36

In both these cases, I actually added new name:eng_x_variant and name:eng_x_preferred values, but the label: prefix was used to set the new properties instead.

iandees commented 4 years ago

Can you be a little more specific about the steps you did here? It looks like you tried adding a language by adding text to the "Filter" box and then specified a preferred and variant value?

iandees commented 4 years ago

Ah, found the problem and it's fixed now. :+1:

stepps00 commented 4 years ago

Nice, thanks! Just in case, steps that caused this:

Add value the Localized Names "variant" text field with "Eng" selected as the language ("name:eng_x_variant")
Add value the Localized Names "preferred" text field with "Eng" selected as the language ("name:eng_x_preferred")
Propose changes to GitHub
In the PR, notice the prefix for the new properties is label, not name.

stepps00 commented 4 years ago

Confirmed fix: https://github.com/whosonfirst-data/whosonfirst-data-admin-in/pull/37/files