iandotkelly / nlf

Node License Finder
MIT License
153 stars 41 forks source link

Resolve issue where github URLs are reported as http://wwwhub.com #56

Closed TheSpyder closed 5 years ago

TheSpyder commented 5 years ago

For projects that use "url": "https://github.com/DefinitelyTyped/DefinitelyTyped.git" the old regex worked fine, but some are now using "url": "https://www.github.com/DefinitelyTyped/DefinitelyTyped.git" which comes back as wwwhub.

Simple regex fix and I also added a test.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.01%) to 95.402% when pulling 1a298bbae341d53b4fa6fc155409848af11ecce7 on TheSpyder:github_repositories into 5e1ea2ca3adb5d44b33c7775e72d82c820fbcf14 on iandotkelly:master.

iandotkelly commented 5 years ago

Merged and released as v2.1.1 - thank you.