search

iandunn / admin-notice-helper

Helps WordPress plugins and themes display messages/errors to the user within the Admin Panels
GNU General Public License v2.0
33 stars 7 forks source link

Fixed Class Issue With WordPress 4.1.1 #3

Closed varunsridharan closed 9 years ago

varunsridharan commented 9 years ago

Fixed Class render issue with wordpress 4.1.1 Added Twitter Bootstrap Style. ['block','update','error','info']

Bootstrap alert style from [http://cssdeck.com/labs/twitter-bootstrap-alerts]

Total 2 styles are available now 1. WordPress Default | 2. Twitter Bootstrap Configure by editing template variable.

iandunn commented 9 years ago

Thanks for the PR. I'm not interested in supporting Bootstrap at the moment, but I'm curious about the 4.1.1 rendering issue.

The diff looks like it has a lot of unrelated changes, so it's difficult to tell what the rendering issue is; could you describe it?

The best practice when sending PRs is to send separate PRs for each issue, and to make sure there aren't any unrelated changes in each request. That helps to keep things organized and makes it easier to review.