search

ianengelbrecht / geo-coordinates-parser

A Javascript function for reading a variety of coordinate formats and converting to decimal numbers. Builds on other efforts by returning the verbatim coordinates and the decimal coordinates all in one object.
MIT License
38 stars 9 forks source link

Fix types #19

Closed tibotiber closed 3 weeks ago

tibotiber commented 3 weeks ago

Hi, really handy library, thank you. I'm a typescript user and realized that the types defined are wrong as the 2 decimal coordinates are numbers, not string. Here is a proposed quick fix.

I'm not familiar with this build setup for types, but that's the only place I found anything in the form of type declarations, so hopefully it works.

Happy to iterate if needed.

ianengelbrecht commented 3 weeks ago

Thank you very much, greatly appreciated (and not sure how that slipped through the cracks TBH!)

ianengelbrecht commented 3 weeks ago

Merged and published

tibotiber commented 3 weeks ago

Lovely, thanks for the quick merge. And these cracks are always there, just for the community to feel involved ;)

tibotiber commented 3 weeks ago

PS: could you ping here once published to npm?

ianengelbrecht commented 3 weeks ago

Yes it's up on npm, please check the version bump there, should be 1.7.4

tibotiber commented 3 weeks ago

Yep, I see it now 🙌