ianeta / javaothelloreversi

Automatically exported from code.google.com/p/javaothelloreversi
0 stars 0 forks source link

Review command pattern. #2

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Let's focus on the Command pattern and CommandTest.

Original issue reported on code.google.com by noth...@gmail.com on 8 Dec 2009 at 7:17

GoogleCodeExporter commented 9 years ago
To make a test which expects an exception is thrown can be done using this 
technique:
http://junit.sourceforge.net/doc/faq/faq.htm#tests_7

Some suggestions about the tests:
1. each test should test a single specific area - this makes tests simple and 
easy 
to identify the problems when failed.
2. when testing Command, we don't need to test Board - we have already done so, 
aren't we? Hence, no need to test cb.getPiece() before the assert.

Original comment by ricky0...@gmail.com on 9 Dec 2009 at 9:35

GoogleCodeExporter commented 9 years ago
Hey thanks !!!   I have missed the junit faq !!!! When I visited www.junit.org, 
I
felt hopeless!

It's good to be commented because there is always something that I cannot judge 
by
myself......

1. You are right !! I've read this but failed to write it..
2. Yes too!! I tend to slip to functional test from unit test.....

Original comment by noth...@gmail.com on 9 Dec 2009 at 9:42