Closed ianfab closed 6 years ago
OK Sir.ianfab. If i found bug. I will post report a problem . regard. woradet
I think. Is it possible? problem is Make KXK drawish if counting is enabled. https://github.com/ianfab/Makruk-Stockfish/commit/d782b1f970b0cc5f041f323f5b98a4a73edf69ef
@woradet Could you please explain a bit more what you mean? https://github.com/ianfab/Makruk-Stockfish/commit/d782b1f970b0cc5f041f323f5b98a4a73edf69ef does not seem to be related to this issue, since the KXK evaluation function is only used if the weaker side has at most a pawn or a queen left, which is not the case in the above example.
The main issue in the above game is the scale factor for positions where the stronger side only has one pawn left. The stronger side avoids to promote, because it would otherwise be left with only one pawn.
Sorry I mean No attacking sometime of ai. I'm just predicting.
From yours position that Mr.Woradet post. it Special case of Thai technique it call Maemaipiset (Special case) if you like to make it moves correctly you should compile Valuesend of pieces different in this case I suggest write QueenValueEg 401 but KnightValueMg and KnightValueEg it the same equal 800 and engines will know how to zigzag or know how to move better position. Because it only 1 point different it make line of Engine thinking different. Normally it Think 1 captures 2 pieces it good for make the game advancetage. And another case you should try BishopEg 801 and KnightValueMg and KnightValueEg = 800 it will make engine know Autoboard it mean automatic thinking it Advance mode. But Engine must have right Values it will make good games or know Endgame.
Mstpcst
This is PGN that stockfish that I develop from you source code moves likes this from Mr.Woradet post.
[Event "Local Event"] [Site "Local Site"] [Date "2018.02.01"] [Round "1"] [White "Stockfish Makruk E55310118 64"] [Black "Stockfish Makruk E55310118 64"] [Result "1-0"] [Variant "Makruk"] [SetUp "1"] [FEN "2r1mR2/8/2M5/PP6/8/2K5/5nk1/5N2 w - - 0 1"] [PlyCount "91"]
@Mstpcst If you think you found an improvement to the code, it would be nice if you could run a match between the current and your version to check whether the change improves playing strength.
OK and now my friend make stockfish run in win board I will try more it better than pychess but the code of KBQK it important and autoboard I will tell you more.
I pushed https://github.com/ianfab/Makruk-Stockfish/commit/e8189ecc535ec45ea5fac89164cfe7aa73d1a601, which includes changes of the endgame code and the passed pawn evaluation. It should remove some artifacts in evaluation and play. Testing and feedback is very welcome.
Thank you sir.ianfab For your develop. for case KNQK , program must know if it move to the same conner that queen square it will checkmate but if it move to another conner that opposite queen attack it mean draw.
normaly only 20 percent it checkmate by wrong move king to the same conner of Queen opposite side. I hope you understand what I mean. Many Thanks
@woradet There is no heuristic implemented yet for the KNQK endgame (all positions are evaluated as draw there), so it is no surprise that it might blunder in that endgame. The pull request #5 proposes a possible implementation to fix that, but the evaluation of this PR would need some correction as the endgame KNQK can only be won if the king is already close to the right corner.
@woradet With the current version, I do not observe any more issues with Stockfish avoiding pawn promotion. If you can still reproduce such issues, please let me know, otherwise I will close this issue,
It's OK.Sir Thank you very much
Ok, thanks.
game posted by @woradet
Should be mainly caused by
SCALE_FACTOR_ONEPAWN
, but more changes might be necessary to fully address that.