search

ianfab / fairyground

playground for Fairy-Stockfish in the browser
https://fairyground.vercel.app/
GNU General Public License v3.0
20 stars 5 forks source link

PGN/EPD Parsing Feature & Fixes #73

Closed yjf2002ghty closed 1 month ago

yjf2002ghty commented 2 months ago

New Feature

  1. Added a simple PGN / EPD parser which can open PGN and EPD files and do basic operations on the list.
  2. Position Variants is now able to load UCI moves.
  3. Added resources.html so that end users can get chess variant resources.

Fixes

  1. Now the UI can correctly handle & remove invalid (illegal) moves.
  2. Now end users can load external binary engines in online versions.
  3. Now the default notation generation has been disabled since it breaks program logic (reported via Discord)
  4. Now the UI will stop in browser FSF correctly to avoid race condition (reported via Discord)
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairyground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 9:31am
yjf2002ghty commented 2 months ago

tmp3.zip

This is the archive attachment.

The reason why I mark this pull request as draft is mainly this problem.

yjf2002ghty commented 2 months ago

Hi @ianfab , did you have any idea on the error in ffish.js library? I've changed this pull request to "Open" to make it ready for merging as this problem is not so serious as I thought and the warning on large files should be enough to warn the users about this issue. I want to prevent this pull request from staying stagnant for a long time as it might conflict with PRs later.

ianfab commented 2 months ago

Sorry, I didn't have time yet to look into this PR. However, regarding the resources page, I would like to avoid duplicating documentation and maintain such information only on the official website. If you feel like anything is missing on the website, feel free to suggest to add it there.

yjf2002ghty commented 2 months ago

I've trimmed the resources page. It only contains links to the official websites now.

The page is intended to be a link page that direct the users to the official websites including fsf homepage and chess variant homepage. This would help new users to find these official websites.

yjf2002ghty commented 2 months ago

@ianfab I've fixed the problem. The reason is that I forgot to call board.delete() after I created a lot of temporary boards and caused heap overflow. Now all things are going well and it's ready to merge.

ianfab commented 1 month ago

Thanks, and sorry for the recent inactivity, will try to catch up with PRs.