Fix for 465 - Githubissues

ianfhunter commented 4 months ago

Description

This should fix #465, as the test case is working for me locally. The issue was a bad assignment in the part of the if statement that checked if the Keep amount was too high. The local pointer for the function changed, but not the caller's pointer, when the function finished, the wrong memory was set.

:bug: Fixes #465 🧹 Cleanup of variable name differences 🧹 drop/keep functions properly reflect their function - not copy paste 🧪 New test to ensure this case does not fail again

How Has This Been Tested

Added a test for this scenario in pytest suite

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Test Coverage (Additional test(s) without any extra code)
[ ] Documentation Improvements
[ ] Code Quality / Maintenance

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation & I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I give my permission for my code to be used in this project under this license and any future license terms

ianfhunter commented 4 months ago

Hmm Fixed in C but python crashing. Usually that means there's still some memory issue around