Huge numbers for dice - Githubissues

ianfhunter / GNOLL

GNOLL is an efficient dice notation parser for multiple programming languages that supports a wide set of dice notation

https://www.ianhunter.ie/GNOLL/

GNU General Public License v3.0

40 stars 24 forks source link

Huge numbers for dice #472

Closed ianfhunter closed 8 months ago

ianfhunter commented 8 months ago

Description

⬆️ Increase size of dice allowed by: 1d2147483647 ->1d9223372036854775807 🦺 Start to catch over/underflow issues

How Has This Been Tested

Change Type

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Test Coverage (Additional test(s) without any extra code)
[ ] Documentation Improvements
[ ] Code Quality / Maintenance

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation & I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I give my permission for my code to be used in this project under this license and any future license terms

ianfhunter commented 8 months ago

maybe better to do this in parts

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud