search

ianfhunter / TeamCrab

Group Project for CS4098
MIT License
0 stars 1 forks source link

Default scenarios #14

Closed lardnerl closed 10 years ago

lardnerl commented 10 years ago

I have been thinking that to make these easier to implement it might be worth restructuring the back end. Things like culture do not actually need a class - nothing in them changes, they are purely a source of data. They could just be contained as a dict or map structure in the config file. The same could be done for skeletons for teams and locations.

scottcunningham commented 10 years ago

Makes sense. The encapsulation of keeping them in a class is still nice, though, so I don't see the point of dropping it. Instead, you could implement them as a class that inherits from dict so that they have everything that dict does including the vanity constructor s = Scenario(some_dict) On 18 Feb 2014 14:08, "lardnerl" notifications@github.com wrote:

I have been thinking that to make these easier to implement it might be worth restructuring the back end. Things like culture do not actually need a class - nothing in them changes, they are purely a source of data. They could just be contained as a dict or map structure in the config file. The same could be done for skeletons for teams and locations.

Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14 .

lardnerl commented 10 years ago

Our global_config file - what is the name for how we have done that file? and how do you have labels point to pairs or lists?

On 18 February 2014 14:49, Scott Cunningham notifications@github.comwrote:

Makes sense. The encapsulation of keeping them in a class is still nice, though, so I don't see the point of dropping it. Instead, you could implement them as a class that inherits from dict so that they have everything that dict does including the vanity constructor s = Scenario(some_dict) On 18 Feb 2014 14:08, "lardnerl" notifications@github.com wrote:

I have been thinking that to make these easier to implement it might be worth restructuring the back end. Things like culture do not actually need a class - nothing in them changes, they are purely a source of data. They could just be contained as a dict or map structure in the config file. The same could be done for skeletons for teams and locations.

Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/14> .

Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-35390717 .

rogersst commented 10 years ago

I'm not sure what name you would put on it. It's just a file containing a python dictionary. And for pointing a label to pairs or lists, you can just do:

"pair" : (1, 2),
"list" : [1, 2, 3, 4, 5]
scottcunningham commented 10 years ago

It's a dictionary. In python, {} represents a dict. Python's type system allows you to have any type as the value in the key value pairs. On 18 Feb 2014 17:11, "lardnerl" notifications@github.com wrote:

Our global_config file - what is the name for how we have done that file? and how do you have labels point to pairs or lists?

On 18 February 2014 14:49, Scott Cunningham <notifications@github.com

wrote:

Makes sense. The encapsulation of keeping them in a class is still nice, though, so I don't see the point of dropping it. Instead, you could implement them as a class that inherits from dict so that they have everything that dict does including the vanity constructor s = Scenario(some_dict) On 18 Feb 2014 14:08, "lardnerl" notifications@github.com wrote:

I have been thinking that to make these easier to implement it might be worth restructuring the back end. Things like culture do not actually need a class - nothing in them changes, they are purely a source of data. They could just be contained as a dict or map structure in the config file. The same could be done for skeletons for teams and locations.

Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/14> .

Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-35390717> .

Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-35407668 .

ianfhunter commented 10 years ago

3 is good enough for this as we agreed in the meeting. Closed.

ianfhunter commented 10 years ago

From Todo -

Stephen - import all scenarios in one file and keep as list" Also To rename scenarios "Hugh - Eastern Europe Scenario

rogersst commented 10 years ago

I refactored the scenarios in 0241da33a94bf29fb9bb0937b8f81e02e49610e1. There's a section in the README now about the code structure for scenarios.

ianfhunter commented 10 years ago

@lardnerl (for the creation of the third scenario) @rogersst (modify existing scenarios) @scottcunningham (to be aware of this as implementing #23 )

Don't forget that the simulations should be of three different revenues tiers - high (€20 million/year), medium (€5 million/year), low (€1 million).

ianfhunter commented 10 years ago

@lardnerl That should be "Dublin & Eastern Europe", sorry

ianfhunter commented 10 years ago

If you need map coordinates, just tell me which ones and ill give you a rough estimate xy

lardnerl commented 10 years ago

Added "Dublin & Eastern Europe" scenario.

scottcunningham commented 10 years ago

Poland is in Central Europe... like it's right beside Germany https://maps.google.com/maps?q=poland&hl=en&ll=52.61639,21.796875&spn=15.454031,39.331055&sll=37.0625,-95.677068&sspn=40.137381,78.662109&hnear=Poland&t=m&z=5

On 6 March 2014 13:15, lardnerl notifications@github.com wrote:

Added "Dublin & Eastern Europe" scenario.

Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-36886319 .

lardnerl commented 10 years ago

http://en.wikipedia.org/wiki/Eastern_Europe

On 6 March 2014 13:39, Scott Cunningham notifications@github.com wrote:

Poland is in Central Europe... like it's right beside Germany

https://maps.google.com/maps?q=poland&hl=en&ll=52.61639,21.796875&spn=15.454031,39.331055&sll=37.0625,-95.677068&sspn=40.137381,78.662109&hnear=Poland&t=m&z=5

On 6 March 2014 13:15, lardnerl notifications@github.com wrote:

Added "Dublin & Eastern Europe" scenario.

Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-36886319>

.

Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-36888079 .

scottcunningham commented 10 years ago

http://en.wikipedia.org/wiki/Poland

"Poland [image: Listen]http://upload.wikimedia.org/wikipedia/commons/d/de/En-us-Poland.ogg i http://en.wikipedia.org/wiki/File:En-us-Poland.ogg/http://en.wikipedia.org/wiki/Help:IPA_for_English ˈ http://en.wikipedia.org/wiki/Help:IPA_for_English#Keyphttp://en.wikipedia.org/wiki/Help:IPA_for_English#Key oʊ http://en.wikipedia.org/wiki/Help:IPA_for_English#Keylhttp://en.wikipedia.org/wiki/Help:IPA_for_English#Key ə http://en.wikipedia.org/wiki/Help:IPA_for_English#Keynhttp://en.wikipedia.org/wiki/Help:IPA_for_English#Key d http://en.wikipedia.org/wiki/Help:IPA_for_English#Key/http://en.wikipedia.org/wiki/Help:IPA_for_English( Polish http://en.wikipedia.org/wiki/Polish_language: Polska), officially the Republic of Poland (Polishhttp://en.wikipedia.org/wiki/Polish_language: Rzeczpospolita http://en.wikipedia.org/wiki/Rzeczpospolita Polska), is a country in Central Europe http://en.wikipedia.org/wiki/Central_Europe"

On 6 March 2014 13:55, lardnerl notifications@github.com wrote:

http://en.wikipedia.org/wiki/Eastern_Europe

On 6 March 2014 13:39, Scott Cunningham notifications@github.com wrote:

Poland is in Central Europe... like it's right beside Germany

https://maps.google.com/maps?q=poland&hl=en&ll=52.61639,21.796875&spn=15.454031,39.331055&sll=37.0625,-95.677068&sspn=40.137381,78.662109&hnear=Poland&t=m&z=5

On 6 March 2014 13:15, lardnerl notifications@github.com wrote:

Added "Dublin & Eastern Europe" scenario.

Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-36886319>

.

Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-36888079>

.

— Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-36889463 .

ianfhunter commented 10 years ago

Changed to Belarus. :earth_americas:

ianfhunter commented 10 years ago

I presume our other scenarios are fine as they are quite extensive, but the other two suggested were:

  1. Dublin, New York, Shanghai
  2. Dublin, San Francisco, Bangalore
ianfhunter commented 10 years ago

Okay to above.

Reopening - Include scenario details in either the menu - Ian

ianfhunter commented 10 years ago

Preliminary one up now. needs more stats

ianfhunter commented 10 years ago

Added additional information in 204289222eadbdd14922ed6cca3873386e3a0591. Should be okay now.

scottcunningham commented 10 years ago

good job!

On 12 March 2014 22:13, Ian Hunter notifications@github.com wrote:

Added additional information in 2042892https://github.com/ianfhunter/TeamCrab/commit/204289222eadbdd14922ed6cca3873386e3a0591. Should be okay now.

Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/14#issuecomment-37475714 .