Closed ianfhunter closed 10 years ago
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60 .
Yeah I presume its the same way we did it before. On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592 .
This is the line that broke it: https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L15
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681 .
Actually no, that's wrong. Sorry. Looking into it again now.
On 5 April 2014 19:30, Scott Cunningham cunninsc@tcd.ie wrote:
This is the line that broke it: https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L15
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681 .
Think it's this: https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L115 Will try fix now!
On 5 April 2014 19:31, Scott Cunningham cunninsc@tcd.ie wrote:
Actually no, that's wrong. Sorry. Looking into it again now.
On 5 April 2014 19:30, Scott Cunningham cunninsc@tcd.ie wrote:
This is the line that broke it: https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L15
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681 .
Done, someone verify please!
On 5 April 2014 19:32, Scott Cunningham cunninsc@tcd.ie wrote:
Think it's this:
https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L115 Will try fix now!
On 5 April 2014 19:31, Scott Cunningham cunninsc@tcd.ie wrote:
Actually no, that's wrong. Sorry. Looking into it again now.
On 5 April 2014 19:30, Scott Cunningham cunninsc@tcd.ie wrote:
This is the line that broke it: https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L15
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681 .
wow
On 5 April 2014 19:41, Scott Cunningham notifications@github.com wrote:
Done, someone verify please!
On 5 April 2014 19:32, Scott Cunningham cunninsc@tcd.ie wrote:
Think it's this:
https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L115 Will try fix now!
On 5 April 2014 19:31, Scott Cunningham cunninsc@tcd.ie wrote:
Actually no, that's wrong. Sorry. Looking into it again now.
On 5 April 2014 19:30, Scott Cunningham cunninsc@tcd.ie wrote:
This is the line that broke it:
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub<
https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39647064 .
But yeah, it looks good to me!
On 5 April 2014 19:56, Stephen Rogers rogers4815@gmail.com wrote:
wow
On 5 April 2014 19:41, Scott Cunningham notifications@github.com wrote:
Done, someone verify please!
On 5 April 2014 19:32, Scott Cunningham cunninsc@tcd.ie wrote:
Think it's this:
https://github.com/ianfhunter/TeamCrab/commit/45b9ba54d3e4e97c9431a7979219832e525bdd97#diff-f5e40ad2118124d961b9f00b31c59514L115 Will try fix now!
On 5 April 2014 19:31, Scott Cunningham cunninsc@tcd.ie wrote:
Actually no, that's wrong. Sorry. Looking into it again now.
On 5 April 2014 19:30, Scott Cunningham cunninsc@tcd.ie wrote:
This is the line that broke it:
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub<
https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39647064 .
such fix many bug
On 5 April 2014 19:57, rogersst notifications@github.com wrote:
But yeah, it looks good to me!
On 5 April 2014 19:56, Stephen Rogers rogers4815@gmail.com wrote:
wow
On 5 April 2014 19:41, Scott Cunningham notifications@github.com wrote:
Done, someone verify please!
On 5 April 2014 19:32, Scott Cunningham cunninsc@tcd.ie wrote:
Think it's this:
Will try fix now!
On 5 April 2014 19:31, Scott Cunningham cunninsc@tcd.ie wrote:
Actually no, that's wrong. Sorry. Looking into it again now.
On 5 April 2014 19:30, Scott Cunningham cunninsc@tcd.ie wrote:
This is the line that broke it:
On 5 April 2014 19:29, Ian Hunter notifications@github.com wrote:
Yeah I presume its the same way we did it before.
On 5 Apr 2014 19:26, "rogersst" notifications@github.com wrote:
This should be a fairly simple fix to make. A scenario is actually loaded, the name just isn't showing up in the box.
On 5 April 2014 19:11, Ian Hunter notifications@github.com wrote:
This was disabled when new JSON scenarios were made, reenable
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60> .
Reply to this email directly or view it on GitHub<
https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646592>
.
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39646681>
.
Reply to this email directly or view it on GitHub< https://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39647064>
.
Reply to this email directly or view it on GitHubhttps://github.com/ianfhunter/TeamCrab/issues/60#issuecomment-39647540 .
GG v quick
This was disabled when new JSON scenarios were made, reenable